Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static

From: Kishon Vijay Abraham I
Date: Fri Sep 02 2016 - 08:15:49 EST


Hi,

On Wednesday 31 August 2016 03:31 PM, Arnd Bergmann wrote:
> On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is
>> declared and don't need a declaration, but can be made static.
>> So this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
>>
>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Same comment as for the other patch, it's better to use "phy: tegra: ..."
> in the subject for clarity.

Fixed it myself and merged this and the other patch.

Thanks
Kishon