Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus

From: Maxime Ripard
Date: Mon Sep 05 2016 - 15:31:19 EST


Hi Jorik,

On Sat, Sep 03, 2016 at 02:09:32PM +0200, Jorik Jonker wrote:
> On Fri, Sep 02, 2016 at 09:04:25AM +0200, Maxime Ripard wrote:
> >Unfortunately, these pins can be used for other purposes as well, so
> >we cannot make force that decision down to our users.
>
> Yes, but since the associated peripheral is disabled, the users are free to
> configure other functions/peripherals, right? I mean something like this in
> pseudo-DT:
>
> /soc/pio: pinctrl@01c20800/uart1_pins:
> allwinner,pins = "PG6, PG7";
> /soc/pio: pinctrl@01c20800/foo0_pins:
> allwinner,pins = "PG6, PG7";
> ..
> /soc/uart1: serial@serial@01c28400:
> pinctrl-0 = <&uart1_pins>;
> status = "disabled";
> /soc/bar:
> pinctrl-0 = <&uart1_pins>;
> status = "disabled";
>
> Assuming Linux/DT allows this, this would force nothing, only offer choice
> and ease of use.

Hmm, sorry, I went over your patches too quickly...

That's a great compromise I think. Chen-Yu, any opinion on this?

Thanks,
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature