Re: [PATCH 4/7] serial: 8250_fintek: Rearrange function

From: Ji-Ze Hong (Peter Hong)
Date: Mon Sep 05 2016 - 21:56:30 EST


Hi Ricardo, Greg,

Ricardo Ribalda Delgado æ 2016/9/1 äå 07:17 åé:
On one previous patch you almost rewrote theset_irq_mode function and
added the prototype. It might be a good moment to move the whole
function up.


I had try with merge the following 2 patches in local,
1: serial: 8250_fintek: Set IRQ Mode when port probed
2: serial: 8250_fintek: Rearrange function

but it made the patch less readable. So I'll try to add
set_irq() with prototype first, and change this function location
with other patch.

Could you give me some comments, Greg? Should I merge it?

Thanks
--
With Best Regards,
Peter Hong