Re: [PATCH V2 2/2] mm: Add sysfs interface to dump each node's zonelist information

From: Anshuman Khandual
Date: Tue Sep 06 2016 - 02:49:18 EST


On 09/06/2016 11:41 AM, kbuild test robot wrote:
> Hi Anshuman,
>
> [auto build test ERROR on mmotm/master]
> [also build test ERROR on v4.8-rc5 next-20160905]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-Export-definition-of-zone_names-array-through-mmzone-h/20160906-133749
> base: git://git.cmpxchg.org/linux-mmotm.git master
> config: x86_64-randconfig-x013-201636 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> drivers/base/memory.c: In function 'dump_zonelists':
>>> >> drivers/base/memory.c:474:20: error: 'ZONELIST_NOFALLBACK' undeclared (first use in this function)
> node_zonelists[ZONELIST_NOFALLBACK]);
> ^~~~~~~~~~~~~~~~~~~
> drivers/base/memory.c:474:20: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +/ZONELIST_NOFALLBACK +474 drivers/base/memory.c
>
> 468 node_zonelists[ZONELIST_FALLBACK]);
> 469 count += sprintf(buf + count, "[NODE (%d)]\n", node);
> 470 count += sprintf(buf + count, "\tZONELIST_FALLBACK\n");
> 471 count += dump_zonelist(buf + count, zonelist);
> 472
> 473 zonelist = &(NODE_DATA(node)->
> > 474 node_zonelists[ZONELIST_NOFALLBACK]);
> 475 count += sprintf(buf + count, "\tZONELIST_NOFALLBACK\n");

Missed the fact that ZONELIST_NOFALLBACK is valid only on CONFIG_NUMA
systems. Will fix and resend the patch.