Re: [PATCH] net: hns: declare function as static

From: David Miller
Date: Tue Sep 06 2016 - 19:21:04 EST


From: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
Date: Tue, 6 Sep 2016 19:53:11 +0800

> Declare function as static to kill warning about missing-prototypes.
>
> Cc: Yisen Zhuang <yisen.zhuang@xxxxxxxxxx>
> Cc: Kejian Yan <yankejian@xxxxxxxxxx>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
...
> @@ -73,7 +73,7 @@ static struct ring_pair_cb *hns_ae_get_ring_pair(struct hnae_queue *q)
> return container_of(q, struct ring_pair_cb, q);
> }
>
> -struct hnae_handle *hns_ae_get_handle(struct hnae_ae_dev *dev,
> +static struct hnae_handle *hns_ae_get_handle(struct hnae_ae_dev *dev,
> u32 port_id)

You have to adjust the indentation of the arguments on the following lines
if you change where the openning parenthesis is. They must start exactly
at the column folling that openning parenthesis.