Re: [PATCH v2 13/33] Define CONFIG_INTEL_RDT

[Thomas Gleixner]

On Thu, 8 Sep 2016, Fenghua Yu wrote:
> From: Vikas Shivappa <vikas.shivappa@xxxxxxxxxxxxxxx>

This changelog is still utter crap.

> CONFIG_INTEL_RDT is defined.

We know already from $subject that CONFIG_INTEL_RDT is introduced.

>                              The option provides support for resource
> allocation which is a sub-feature of Intel Resource Director Technology
> (RDT).

The config switch says:
 
> +config INTEL_RDT
> +	bool "Intel Resource Director Technology support"

So what? Is this now resource allocation or resource director or does the
actual stuff introduce something completely different?

> +	default n
> +	depends on X86_64 && CPU_SUP_INTEL

Why is this 64bit only? The changelog and/or the help text should tell
that.

> +	help
> +	  This option provides support for resource allocation which is a
> +	  sub-feature of Intel Resource Director Technology(RDT).

Sure and you repeat the changelog nonsense here again.

> +	  Current implementation supports L3 cache allocation.
> +	  Using this feature a user can specify the amount of L3 cache space
> +	  into which an application can fill.

Sigh

	tglx