RE: [patch v4] leds: add driver for Mellanox systems LEDs

From: Vadim Pasternak
Date: Thu Sep 08 2016 - 07:11:46 EST




> -----Original Message-----
> From: Jacek Anaszewski [mailto:j.anaszewski@xxxxxxxxxxx]
> Sent: Thursday, September 08, 2016 1:24 PM
> To: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; rpurdie@xxxxxxxxx
> Cc: dave@xxxxxxxxxxx; linux-leds@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> jiri@xxxxxxxxxxx; Michael Shych <michaelsh@xxxxxxxxxxxx>
> Subject: Re: [patch v4] leds: add driver for Mellanox systems LEDs
>
> On 09/08/2016 12:20 PM, Jacek Anaszewski wrote:
> > On 09/08/2016 09:25 AM, vadimp@xxxxxxxxxxxx wrote:
> >> From: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> >
> >> diff --git a/Documentation/leds/leds-mlxcpld.txt
> >> b/Documentation/leds/leds-mlxcpld.txt
> >> new file mode 100644
> >> index 0000000..7b4c2a3
> >> --- /dev/null
> >> +++ b/Documentation/leds/leds-mlxcpld.txt
> >> @@ -0,0 +1,110 @@
> >> +ver LEDs-mlxcpld
> >
> > I noticed this only now - is it a stray line or you intended it was
> > something more meaningful?
>
> OK, I changed it to:
>
> Kernel driver for Mellanox systems LEDs
> =======================================
>
> followed by an empty line.
>
> >> +==========================
> >> +Driver for Mellanox systems LEDs.
> >> +Provide system LED support for the nex Mellanox systems:
> >> +"msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
> >> +"msb7800", "msn2740", "msn2100".
> >
> >
OK.
Thank you very much for reviews.

When we'll have some docs available at WEB, I'll update leds-mlxcpld.txt with it.

Best regards,
Vadim.
>
>
> --
> Best regards,
> Jacek Anaszewski