Re: [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

From: Suzuki K Poulose
Date: Mon Sep 12 2016 - 06:35:49 EST


On 12/09/16 11:33, Baoyou Xie wrote:
We get 1 warning when building kernel with W=1:
drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes]

In fact, this function is used in a few files,
but should be declared in a header file.

So this patch adds the declaration in arm-cci.h.

Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
---
include/linux/arm-cci.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h
index 521ec1f..b88f6fb 100644
--- a/include/linux/arm-cci.h
+++ b/include/linux/arm-cci.h
@@ -30,8 +30,10 @@ struct device_node;

#ifdef CONFIG_ARM_CCI
extern bool cci_probed(void);
+extern asmlinkage void __naked cci_enable_port_for_self(void);
#else
static inline bool cci_probed(void) { return false; }
+static inline void ci_enable_port_for_self(void) { return; }
#endif


Don't you think the above definitions should depend on

ARM_CCI400_PORT_CTRL than ARM_CCI ?


Suzuki