Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional

From: Leo Li
Date: Mon Sep 12 2016 - 12:47:48 EST


On Fri, Sep 9, 2016 at 3:59 PM, Uwe Kleine-KÃnig
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> Hello,
>
> On Fri, Sep 09, 2016 at 01:34:31PM -0700, Stefan Agner wrote:
>> Yeah it is a bit a wording thing: In my understanding, pinctrl is
>> required on SoC's witch have a pin controller... It is just that the
>> driver does not need to get the pinctrl by itself because the stack is
>> taking care of it implicitly. And yes, that makes the particular example
>> not a real world example.
>
> At first I thought, too, that it's a fatal problem if getting the
> pinctrl stuff fails. IMHO that shows that the comments (or the code) are
> still not good enough.

Ya. If it has confused more than one people, it is likely to confuse
more. I agree with you that we should make it more clear.

Thanks,
Leo