Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
From: Julia Lawall
Date: Tue Sep 13 2016 - 05:57:21 EST
On Tue, 13 Sep 2016, Namrata A Shettar wrote:
> Yes I realize that this may be wrong.Thank you for your inputs!
> ÂAlso,The version of the kernel I am using is : 4.8.0-rc2+
You should be using what you get by doing the following command:
git clone -b staging-testing git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Maybe this is what you already have?
> On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote:
> On Tue, 13 Sep 2016, Arnd Bergmann wrote:
> > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A
> Shettar wrote:
> > > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > > @@ -18,7 +18,6 @@
> > >
> > > Â#include <linux/module.h>
> > > Â#include <linux/kernel.h>
> > > -
> > > Â#include "comedi_pcmcia.h"
> > >
> > > Â/**
> > >
> > I would argue that checkpatch is wrong here, it's very common
> to have
> > an empty line between the global and the local header files.
> I forwarded this to Joe Perches, and he pointed out that
> doesn't give a warning for this. ÂNamrata, what version of the
> kernel are
> you using?
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a-
> For more options, visit https://groups.google.com/d/optout.