RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

From: Moore, Robert
Date: Wed Sep 14 2016 - 10:03:51 EST




> -----Original Message-----
> From: Zheng, Lv
> Sent: Tuesday, September 13, 2016 8:11 PM
> To: Moore, Robert <robert.moore@xxxxxxxxx>; Moore, Robert
> <robert.moore@xxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; LKML <linux-
> kernel@xxxxxxxxxxxxxxx>
> Cc: linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; Wysocki, Rafael J
> <rafael.j.wysocki@xxxxxxxxx>; Box, David E <david.e.box@xxxxxxxxx>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
>
> Hi,
>
> > From: linux-acpi-owner@xxxxxxxxxxxxxxx
> > [mailto:linux-acpi-owner@xxxxxxxxxxxxxxx] On Behalf Of Moore, Robert
> > David E <david.e.box@xxxxxxxxx>
> > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> >
> > Well, I never thought I would write a couple lines of code like this,
> > but here is a solution that should make everyone happy.
> >
> > diff --git a/source/components/tables/tbxfload.c
> > b/source/components/tables/tbxfload.c
> > index 6a937b1..73ee1a2 100644
> > --- a/source/components/tables/tbxfload.c
> > +++ b/source/components/tables/tbxfload.c
> > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
> > if (!TablesFailed)
> > {
> > ACPI_INFO ((
> > - "%u ACPI AML tables successfully acquired and loaded\n",
> > + "%u ACPI AML tables successfully acquired and loaded",
> > TablesLoaded));
> > }
> > else
> > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
> > Status = AE_CTRL_TERMINATE;
> > }
> >
> > +#ifdef ACPI_APPLICATION
> > + ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); #endif
> > +
> > +
>
[Moore, Robert]

I have no problem with this, I just want to get it over with.
It is not a big deal, let's leave it at that and not make it a big issue.





> IMO, these lines should be in ACPICA upstream, in a file under
> tools/acpiexec.
>
> Thanks
> Lv
>
> > UnlockAndExit:
> > (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
> > return_ACPI_STATUS (Status);
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi"
> > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
> > info at http://vger.kernel.org/majordomo-info.html