Re: perf/x86: Use kmalloc_array() in merge_attr()

From: SF Markus Elfring
Date: Wed Sep 14 2016 - 13:40:46 EST


>> Would you like to suggest any more constraints for this kind of
>> software refactoring?
>
> Yes, don't do it.

I am bit surprised by this feedback.


> If you're writing new code by all means, do whatever you feel,

Could you accept related software updates then?


> but don't go changing code just because checkpatch.

Why is this not a valid reason for you?

How useful can properties that are provided by a function like
kmalloc_array() be also for software modules which you care about?


Do you find any other software improvements more worthwhile?

Regards,
Markus