Re: drivers: staging: vme: Fixed some code style warnings

From: Markus BÃhme
Date: Wed Sep 14 2016 - 17:47:14 EST


On 09/14/2016 06:31 PM, Andrew Kanner wrote:
> âThanks, I understood my fault, but haven't done this changes yet. I
> can't understand if I should reply to original message with v2 patch or
> send a new email with it?

Just send the patch with your revised commit message as a new mail, and
be sure to mark it as v2.

In future mails, please avoid top-posting. It is frowned upon because it
makes it unnecessarily hard to follow a discussion.

Thanks,
Markus

>
>
> ÐÑÑÐÐÐÐÐ ÑÐÐÐÑÐÐÐÐ
> ÐÑ: Markus BÃhme
> ÐÑÐÑÐÐÐÐÐÐ: ÑÑÐÐÐ, 14 ÑÐÐÑÑÐÑÑ 2016 Ð., 15:56
> ÐÐÐÑ: Andrew Kanner; gregkh@xxxxxxxxxxxxxxxxxxx
> ÐÐÐÐÑ: devel@xxxxxxxxxxxxxxxxxxxx; manohar.vanga@xxxxxxxxx; egor.ulieiskii@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> ÐÐÐÐ: Re: drivers: staging: vme: Fixed some code style warnings
>
> On 09/13/2016 12:31 AM, Andrew Kanner wrote:
>> Signed-off-by: Andrew Kanner <andrew.kanner@xxxxxxxxx>
>> ---
>> drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
>> drivers/staging/vme/devices/vme_user.c | 2 +-
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>> (snip)
>
> Hello Andrew,
>
> please be more specific in your subject line, e.g.
> "drivers: staging: vme: Convert to octal notation for permission bits".
>
> Also don't forget to add a commit message to your patch with a short
> description what you are fixing and why. In your case it would be good
> to mention that you are fixing a checkpatch warning, and to include the
> warning message in your description. Then resend as V2.
>
> Thanks,
> Markus
>