RE: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST_HEAD

[Stuart Yoder]

> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@xxxxxxxxx]
> Sent: Wednesday, September 14, 2016 9:27 PM
> To: J . German Rivera <German.Rivera@xxxxxxxxxxxxx>; Stuart Yoder <stuart.yoder@xxxxxxx>; Greg Kroah-
> Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; German Rivera <german.rivera@xxxxxxx>; Itai Katz
> <itai.katz@xxxxxxx>
> Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST_HEAD
> 
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> 
> Using list_del_init() instead of list_del() + INIT_LIST_HEAD().
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-
> allocator.c
> index 2004fa7..1e06d28 100644
> --- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
> +++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
> @@ -142,8 +142,7 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device
>  		goto out_unlock;
>  	}
> 
> -	list_del(&resource->node);
> -	INIT_LIST_HEAD(&resource->node);
> +	list_del_init(&resource->node);
>  	res_pool->free_count--;
>  	res_pool->max_count--;
> 
> @@ -220,8 +219,7 @@ int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus,
>  		    res_pool->free_count > res_pool->max_count))
>  		goto out_unlock;
> 
> -	list_del(&resource->node);
> -	INIT_LIST_HEAD(&resource->node);
> +	list_del_init(&resource->node);
> 
>  	res_pool->free_count--;
>  	error = 0;

Acked-by: Stuart Yoder <stuart.yoder@xxxxxxx>