Re: [PATCH 2/6 linux-next] ext4: remove unneeded test in ext4_alloc_file_blocks()

From: Theodore Ts'o
Date: Thu Sep 15 2016 - 11:53:34 EST


On Wed, Aug 24, 2016 at 10:03:16PM +0200, Fabian Frederick wrote:
> ext4_alloc_file_blocks() is called from ext4_zero_range() and
> ext4_fallocate() both already testing EXT4_INODE_EXTENTS
> We can call ext_depth(inode) unconditionnally.
>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

Applied, although I also added a BUG_ON() check to make sure
ext4_alloc_file_blocks() won't get called with an indirect-mapped
inode in the future.

- Ted