Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices

From: Vinod Koul
Date: Thu Sep 15 2016 - 12:16:36 EST


On Thu, Sep 15, 2016 at 11:05:12AM +0200, Sylwester Nawrocki wrote:
> On 09/14/2016 08:29 PM, Sam Van Den Berge wrote:
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> ...
> > + { "3c2440-sdi", "rx", (void *)DMACH_SDI },
> > + { "3c2440-sdi", "tx", (void *)DMACH_SDI },
>
> The device names seem misspelled here, and looking at what
> drivers/mmc/host/s3cmci.c driver does we need just a single common
> entry for rx and tx
>
> { "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
>
> With this fixed feel free to add

And please change the title to dmaengine and NOT arm... I was about ti skip
this!

--
~Vinod