Re: [PATCH v3] scripts: add script for translating stack dump function

From: Josh Poimboeuf
Date: Mon Sep 19 2016 - 16:56:47 EST


On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote:
> On Mon, Sep 19, 2016 at 1:00 PM, Rabin Vincent <rabin@xxxxxx> wrote:
> >
> > Note that addr2line has localized strings, so the regex with the " at "
> > won't match for everyone unless you invoke addr2line with LANG=C.
>
> Ok, I'll make it match just on the space instead.
>
> > __write_once_size pà /home/rabinv/dev/linux/include/linux/compiler.h:248
>
> That's an odd localization choice.
>
> "pÃ"? Wouldn't "i" (or perhaps "vid") be a better choice?
>
> Anyway, this works for me in the Swedish locale too. Look ok?
>
> - addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;"
> + addr2line -fpie $objfile $hexaddr |
> + sed "s; $dir_prefix\(\./\)*; ;"
>
> because I certainly hope there is always a space there.

No luck. The Japanese translation uses an empty string:

$ grep -A1 '" at "' binutils/po/ja.po
msgid " at "
msgstr ""

--
Josh