Re: staging/greybus: undefined Kconfig symbols

[Greg KH]

On Wed, Sep 21, 2016 at 12:25:54PM +0200, Valentin Rothberg wrote:
> On Wed, Sep 21, 2016 at 9:39 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, Sep 21, 2016 at 08:30:01AM +0200, Valentin Rothberg wrote:
> >> Hi Greg,
> >
> > <fixing odd email address you used for me...>
> 
> I was a little surprised, too, but that's the one in the signed-off
> field in the greybus commits, so I used it.

Not a problem, but the MAINTAINERS file should have the correct one to
use for this subsystem (it's not just me maintaining it...)

> >> checkkconfigsymbols.py found some undefined Kconfig symbols (see
> >> below) in the Makefile and Kconfig file.  I could not find any patch
> >> adding those symbols.  Are there patches queued somewhere else?
> >>
> >> Best regards,
> >>  Valentin
> >>
> >> GREYBUS_AUDIO_MSM8994
> >> Referencing files: drivers/staging/greybus/Makefile
> >> Similar symbols: GREYBUS_AUDIO, GREYBUS_GPIO, GREYBUS_SDIO, GREYBUS_USB
> >> Commits changing symbol:
> >> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")
> >
> > This one is tricky, as parts of this audio driver depended on an
> > out-of-tree qualcomm audio driver.  It will be unwound over time to not
> > depend on that mess.
> >
> >> MEDIA
> >> Referencing files: drivers/staging/greybus/Kconfig
> >> Similar symbols: COMEDI, EDAC, EISA, HID_CMEDIA, LANMEDIA, MDIO,
> >> MEDIA_CEC, MEDIA_TUNER, MEMDMA0, MEMDMA1
> >> Commits changing symbol:
> >> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")
> >> - 847175e8e660 ("greybus: audio: Fetch jack_mask, button_mask from
> >> module's topology data")
> >> - 64a7e2cceb75 ("greybus: audio: Added jack support to audio module")
> >
> > Ugh, this should be CONFIG_MEDIA_SUPPORT, right?  If so, I'll make a
> > patch to change this, that was my fault.
> 
> Yes, since it's a camera driver, MEDIA_SUPPORT seems to be the good dependency.

Great, I'll make up a patch for this, thanks.

greg k-h