Re: [PATCH v3] taint/module: Clean up global and module taint flags handling

From: Josh Poimboeuf
Date: Wed Sep 21 2016 - 08:07:30 EST


On Wed, Sep 21, 2016 at 01:47:22PM +0200, Petr Mladek wrote:
> The commit 66cc69e34e86a231 ("Fix: module signature vs tracepoints:
> add new TAINT_UNSIGNED_MODULE") updated module_taint_flags() to
> potentially print one more character. But it did not increase the
> size of the corresponding buffers in m_show() and print_modules().
>
> We have recently done the same mistake when adding a taint flag
> for livepatching, see
> https://lkml.kernel.org/g/cfba2c823bb984690b73572aaae1db596b54a082.1472137475.git.jpoimboe@xxxxxxxxxx

No objections to the patch itself, but this link didn't work for me.

Replacing the 'g' with 'r' fixed it:

https://lkml.kernel.org/r/cfba2c823bb984690b73572aaae1db596b54a082.1472137475.git.jpoimboe@xxxxxxxxxx

Or, even better, I think Jiri doesn't rebase his livepatching 'for-next'
branch, so maybe just use the commit id:

2992ef29ae01 ("livepatch/module: make TAINT_LIVEPATCH module-specific")

--
Josh