Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

From: Andrey Utkin
Date: Thu Sep 22 2016 - 16:32:09 EST


On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote:
> removed a space after a cast to obtain the coding style.
>
> Signed-off-by: Jannik Becher <Becher.Jannik@xxxxxxxxx>
> ---
> drivers/staging/wlan-ng/p80211req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
> index 40627d5..ecd2fff 100644
> --- a/drivers/staging/wlan-ng/p80211req.c
> +++ b/drivers/staging/wlan-ng/p80211req.c
> @@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data,
> ----------------------------------------------------------------*/
> int p80211req_dorequest(struct wlandevice *wlandev, u8 *msgbuf)
> {
> - struct p80211msg *msg = (struct p80211msg *) msgbuf;
> + struct p80211msg *msg = (struct p80211msg *)msgbuf;
>
> /* Check to make sure the MSD is running */
> if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT &&

checkpatch.pl shows that in this file there are other occurances of
style deviations - of same or other kinds. Could you please present work
on wider scope, e.g. on whole wlan-ng/, or at last making this one file
to pass checkpatch.pl --strict cleanly?

Not that I don't appreciate this small achievement, but I believe
maintainers won't merge this one, exactly because there is more work of
same kind in the same file.