Re: Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

From: SF Markus Elfring
Date: Sat Sep 24 2016 - 15:51:21 EST


>> Should the desired output be the same when the relevant data are passed by a single function call
>> (instead of three as before)?
>
> Adding a singleton for a pr_fmt #define constant string and
> updating the printk subsystem to prepend that constant string
> to each use of a pr_<level> at runtime would be an improvement
> as it could reduce constant data used by the format strings.

Thanks for for this constructive feedback.


> That would be a _real_ improvement.

This sounds interesting for me too.


> Please try to implement something like that before submitting
> more of these incorrect patches.

Nice wish!

Did any other software developer try to implement such enhanced
logging functionality already?

Regards,
Markus