Re: [PATCH 1/3] netfilter: nf_tables: avoid uninitialized variable warning

From: Pablo Neira Ayuso
Date: Fri Sep 30 2016 - 13:48:07 EST


On Fri, Sep 30, 2016 at 06:05:34PM +0200, Arnd Bergmann wrote:
> The newly added nft_range_eval() function handles the two possible
> nft range operations, but as the compiler warning points out,
> any unexpected value would lead to the 'mismatch' variable being
> used without being initialized:
>
> net/netfilter/nft_range.c: In function 'nft_range_eval':
> net/netfilter/nft_range.c:45:5: error: 'mismatch' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This can be trivially avoided by added a 'default:' clause.

Applied this patch, I took Aaron's and Pai's patches instead.

Thanks anyway for following up on this issue Arnd.