Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to determine roll-forward recovery

From: Chao Yu
Date: Fri Sep 30 2016 - 20:26:52 EST


On 2016/10/1 1:10, Jaegeuk Kim wrote:
> @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> set_ckpt_flags(ckpt, CP_FSCK_FLAG);
>
> + /* set this flag to activate crc|cp_ver for recovery */
> + set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);

Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
cp_lock to protect updating of ckpt_flags").

Thanks,