Re: [PATCH] realtek: rtl8xxxu: Use const init arrays
From: Jes Sorensen
Date: Sat Oct 01 2016 - 14:53:41 EST
Joe Perches <joe@xxxxxxxxxxx> writes:
> Make the init arrays const to reduce data.
> $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: x86-32)
> text data bss dec hex filename
> 80107 13651 58 93816 16e78 drivers/net/wireless/realtek/rtl8xxxu/built-in.o.new
> 65303 28435 58 93796 16e64 drivers/net/wireless/realtek/rtl8xxxu/built-in.o.old
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
In total you grow the kernel by 20 bytes. You reduce the data segment
substantially while growing the text segment instead.
If any architecture replicates the text segment onto individual numa
nodes, this would actually be a real loss rather than a win. Some archs
used to do this, not sure if they are doing it anymore.
I am not against this patch, but I am not sure it's really a win either.