Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms
From: Mark Rutland
Date: Mon Oct 03 2016 - 11:46:58 EST
On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote:
> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes
> which must be aligned on 32 bits addresses.
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/Documentation/devicetree/bindings/net/smsc911x.txt b/Documentation/devicetree/bindings/net/smsc911x.txt
> index 3fed3c124411..224965b7453c 100644
> --- a/Documentation/devicetree/bindings/net/smsc911x.txt
> +++ b/Documentation/devicetree/bindings/net/smsc911x.txt
> @@ -13,6 +13,8 @@ Optional properties:
> - reg-io-width : Specify the size (in bytes) of the IO accesses that
> should be performed on the device. Valid value for SMSC LAN is
> 2 or 4. If it's omitted or invalid, the size would be 2.
> +- reg-u16-align4 : Boolean, put in place the workaround the force all
> + u16 writes to be 32 bits aligned
This property name and description is confusing.
How exactly does this differ from having reg-io-width = <4>, which is
documented immediately above?
> - smsc,irq-active-high : Indicates the IRQ polarity is active-high
> - smsc,irq-push-pull : Indicates the IRQ type is push-pull
> - smsc,force-internal-phy : Forces SMSC LAN controller to use