Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c
From: Joe Perches
Date: Mon Oct 03 2016 - 14:18:36 EST
On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
> El 2016å10æ03æ a las 18:16, Joe Perches escribiÃ:
> > Perhaps better as hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);
> I agree. But because all the code is full of sizeof(struct xxx) I though
> it would be bettter to follow the actual style and not change only one...
> I don't have any problem in fix this patch and resend it. What should I do?
I suggest not fixing this patch.
Maybe just send another patch changing all the applicable
sizeof(struct <foo>) uses to sizeof(*var) with the appropriate