Re: [PATCH V2 1/3] mfd: wm8994-core: don't split lines unnecessarily
From: Lee Jones
Date: Wed Oct 05 2016 - 04:47:04 EST
On Wed, 05 Oct 2016, Viresh Kumar wrote:
> On 04-10-16, 15:41, Lee Jones wrote:
> > On Mon, 03 Oct 2016, Viresh Kumar wrote:
> > > On 16-09-16, 08:56, Viresh Kumar wrote:
> > > > These can fit in a single line (80 columns), don't split lines
> > > > unnecessarily.
> > > >
> > > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > > >
> > > > ---
> > > > V1->V2: New patch
> > > > ---
> > > > drivers/mfd/wm8994-core.c | 6 ++----
> > > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > Ping!!
> > Don't do that!
> Okay, but what's exactly wrong with that? Its been 20 days that I have
> heard anything from you on this. Pinging the maintainers is the only
> option other people have, right?
You are experienced enough to know better than this.
a) Contentless pings have never been acceptable. If you genuinely
think a patch has been forgotten you should resubmit with a
[RESEND]. That is their entire purpose.
b) You submitted this patch right at the end of the release cycle, and
your ping was sent during the merge-window. Most Maintainers, myself
included, like to have patches soak tested in -next for at least a
couple of weeks prior to acceptance.
c) The merge-window is open. We are likely conducting final tests and
formatting pull-requests during this time. As an experienced
submitter, I would have expected you to follow the release cycle and
know that sending patches late is cause for delay.
d) Maintainers take vacations and attend conferences, so some delays
are to be expected.
FYI: Your patch has not slipped through the net. It is in the pile to
be reviewed. Please be more patient, especially around merge time.
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog