Re: [PATCH] fs/block_dev.c: return the right error in thaw_bdev()

From: Jens Axboe
Date: Wed Oct 05 2016 - 16:35:54 EST


On 10/04/2016 03:06 AM, Jan Kara wrote:
On Tue 04-10-16 10:53:40, Pierre Morel wrote:
When triggering thaw-filesystems via magic sysrq, the system enters a
loop in do_thaw_one(), as thaw_bdev() still returns success if
bd_fsfreeze_count == 0. To fix this, let thaw_bdev() always return
error (and simplify the code a bit at the same time).

Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx>

The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Jens, can you please merge this patch? Thanks!

Added, thanks all.

--
Jens Axboe