Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface"
From: Aditya Shankar
Date: Thu Oct 06 2016 - 05:59:07 EST
On Fri, 30 Sep 2016 15:22:15 +0200
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote:
> > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread
> > with workqueue for host interface")
> > This commit breaks wilc1000 driver init. A crash was seen
> > everytime the wlan interface was brought up and wilc device
> > open was attempted. This change is being reverted until we
> > figure out the problem in this change. The driver is
> > usable now with this change reverted.
> > Signed-off-by: Aditya Shankar <Aditya.Shankar@xxxxxxxxxxxxx>
> > Conflicts:
> > drivers/staging/wilc1000/host_interface.c
> What is this line doing here?
> And shouldn't we add a cc: stable tag as well? Or at the least, put a
> "fixes:" tag to let people know exactly what commit it is fixing (the
> id that it is reverting.)
> greg k-h
Apologies for this bad commit message.
I have an update on this wilc1000 crash issue. I've figured out
the cause for the crash and fixed it. Therefore,
I request you to ignore the patch I sent out to
revert the change causing the regression. The cause was a misplaced
call to destroy workqueue soon after creating it.
With this removed, the issue is not seen.
I will send out a separate patch to fix the issue.