Re: [PATCH 3/3] perf, tools: Fix completion script to handle comma list

From: Andi Kleen
Date: Thu Oct 06 2016 - 16:42:06 EST


On Thu, Oct 06, 2016 at 05:29:44PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 06, 2016 at 01:08:39PM -0700, Andi Kleen escreveu:
> > > perf stat -e CPL_CYCLES.RING0
> > >
> > > but if I try:
> > >
> > > perf stat -e cycles,CPL<TAB>
> > >
> > > I get nothing :-\
> > >
> > > Is this working with you?
> >
> > You can't mix cases like this, the upper case patch doesn't support that.
> > It's either all upper or all lower case.
> >
> > If you continue with lower case it should work.
>
> I understand that this should be a limitation of the current patch, but
> if we decide to support completion after a comma, I think people will
> expect that all events will be available :-\

I don't see a simple way to do it. I'm not gonna write a complex parser in shell.

If that really is a requirement the patch has to be withdrawn.

-Andi