Re: Scrolling down broken with "perf top --hierarchy"
From: Namhyung Kim
Date: Fri Oct 07 2016 - 00:54:04 EST
Cc-ing perf maintainers,
On Fri, Oct 07, 2016 at 06:32:29AM +0200, Markus Trippelsdorf wrote:
> On 2016.10.07 at 13:22 +0900, Namhyung Kim wrote:
> > On Fri, Oct 07, 2016 at 05:51:18AM +0200, Markus Trippelsdorf wrote:
> > > On 2016.10.07 at 10:17 +0900, Namhyung Kim wrote:
> > > > On Thu, Oct 06, 2016 at 06:33:33PM +0200, Markus Trippelsdorf wrote:
> > > > > Scrolling down is broken when using "perf top --hierarchy".
> > > > > When it starts up everything is OK and one can scroll up and down to all
> > > > > entries. But as further and further new entries get added to the list,
> > > > > scrolling down is blocked (at the position of the last entry that was
> > > > > shown directly after startup).
> > > >
> > > > I think below patch will fix the problem. Please check.
> > >
> > > Yes. It works fine now. Many thanks.
> > Good. Can I add your Tested-by then?
Ok, I'll send a formal patch with it.
> (And in the long run you should think of making "perf top --hierarchy"
> the default for perf top, because it gives a much better (uncluttered)
> overview of what is going on.)
I think it's a matter of taste. Some people prefer to see the top
single function or something (i.e. current behavior) while others
prefer to see a higher-level view.
But we can think again about the default at least for perf-top. I
worried about changing default behavior because last time we did it
for children mode many people complained about it. But I do think the
hierarchy mode is useful for many people though.
Hmm.. I thought that it already has a config option to enable hierarch
mode by default, but I cannot find it now.