Re: [patch 17/32] greybus: power supply driver

[Pavel Machek]

On Fri 2016-09-16 16:10:58, Greg KH wrote:
> 
> This driver implements the Greybus power supply class protocol.

Probably

POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M:      Sebastian Reichel <sre@xxxxxxxxxx>
M:      Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
M:      David Woodhouse <dwmw2@xxxxxxxxxxxxx>
L:      linux-pm@xxxxxxxxxxxxxxx

should be cc-ed?

> +static int is_cache_valid(struct gb_power_supply *gbpsy)
> +{
...
> +	if (gbpsy->last_update &&
> +	    time_is_after_jiffies(gbpsy->last_update +
> +				  msecs_to_jiffies(cache_time)))
> +		return 1;

Are you sure?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature