Re: [PATCH -v4 1/8] locking/drm: Kill mutex trickery
From: Peter Zijlstra
Date: Fri Oct 07 2016 - 12:13:38 EST
On Fri, Oct 07, 2016 at 08:58:43AM -0700, Linus Torvalds wrote:
> Ugh. I think the concept is fine, but can we place make these enum's
> be all upper case or something to make them really stand out visually.
> The other choice would be to just make the choices be negative (==
> recursive), zero (== failed) or positive (== got lock), which allows
> for the same value re-use for the non-recursive case, and you could
> avoid the enum entirely.
I thought about that, but liked the enum better for having to then spell
I'll go make the enum shout and add comment as you suggest.