Re: [PATCH] wan/fsl_ucc_hdlc: Fix size used in dma_free_coherent()

From: David Miller
Date: Sat Oct 08 2016 - 00:05:48 EST


From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Fri, 7 Oct 2016 22:58:47 +0200

> Size used with 'dma_alloc_coherent()' and 'dma_free_coherent()' should be
> consistent.
> Here, the size of a pointer is used in dma_alloc... and the size of the
> pointed structure is used in dma_free...
>
> This has been spotted with coccinelle, using the following script:
> ////////////////////
> @r@
> expression x0, x1, y0, y1, z0, z1, t0, t1, ret;
> @@
>
> * ret = dma_alloc_coherent(x0, y0, z0, t0);
> ...
> * dma_free_coherent(x1, y1, ret, t1);
>
>
> @script:python@
> y0 << r.y0;
> y1 << r.y1;
>
> @@
> if y1.find(y0) == -1:
> print "WARNING: sizes look different: '%s' vs '%s'" % (y0, y1)
> ////////////////////
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Looks good to me, applied, thanks.