Re: [PATCH] x86/fpu: Remove 'eagerfpu=' docs

From: Ingo Molnar
Date: Sat Oct 08 2016 - 01:39:28 EST



* Andy Lutomirski <luto@xxxxxxxxxx> wrote:

> Now that eagerfpu= is gone, remove it from the docs. Whoops.
>
> Fixes: ca6938a1cd8a ("x86/fpu: Hard-disable lazy FPU mode")
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> ---
> Documentation/kernel-parameters.txt | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 25037ded3683..8083a3432482 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1034,12 +1034,6 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
> nopku [X86] Disable Memory Protection Keys CPU feature found
> in some Intel CPUs.
>
> - eagerfpu= [X86]
> - on enable eager fpu restore
> - off disable eager fpu restore
> - auto selects the default scheme, which automatically
> - enables eagerfpu restore for xsaveopt.
> -
> module.async_probe [KNL]
> Enable asynchronous probe on this module.

Could we make the eagerfpu removal more exhaustive please:

triton:~/tip> git grep -i eagerfpu
Documentation/kernel-parameters.txt: eagerfpu= [X86]
Documentation/kernel-parameters.txt: enables eagerfpu restore for xsaveopt.
arch/x86/include/asm/cpufeatures.h:/* free, was #define X86_FEATURE_EAGER_FPU ( 3*32+29) * "eagerfpu" Non lazy FPU restore */
arch/x86/include/asm/fpu/types.h: * or not. On such CPUs we activate the non-lazy ('eagerfpu')
arch/x86/mm/pkeys.c: * using eagerfpu mode makes this possible.
tools/arch/x86/include/asm/cpufeatures.h:#define X86_FEATURE_EAGER_FPU ( 3*32+29) /* "eagerfpu" Non lazy FPU restore */

Thanks,

Ingo