[PATCH] dlm: free workqueues after the connections

From: Marcelo Ricardo Leitner
Date: Sat Oct 08 2016 - 09:15:19 EST

After backporting commit ee44b4bc054a ("dlm: use sctp 1-to-1 API")
series to a kernel with an older workqueue which didn't use RCU yet, it
was noticed that we are freeing the workqueues in dlm_lowcomms_stop()
too early as free_conn() will try to access that memory for canceling
the queued works if any.

This issue was introduced by commit 0d737a8cfd83 as before it such
attempt to cancel the queued works wasn't performed, so the issue was
not present.

This patch fixes it by simply inverting the free order.

Cc: stable@xxxxxxxxxxxxxxx
Fixes: 0d737a8cfd83 ("dlm: fix race while closing connections")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx>
fs/dlm/lowcomms.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 963016c8f3d12def89c9803eb9d124caa2385dc4..609998de533e894d9cb98f3ff7ef3e05b41d424a 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1656,16 +1656,12 @@ void dlm_lowcomms_stop(void)
dlm_allow_conn = 0;
+ clean_writequeues();
+ foreach_conn(free_conn);


- mutex_lock(&connections_lock);
- clean_writequeues();
- foreach_conn(free_conn);
- mutex_unlock(&connections_lock);