Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb

From: Jarkko Sakkinen
Date: Sat Oct 08 2016 - 12:01:27 EST


On Sat, Oct 08, 2016 at 01:37:31PM +0000, Winkler, Tomas wrote:
> >
> > On Sat, Oct 08, 2016 at 02:59:39PM +0300, Tomas Winkler wrote:
> > > From: "Winkler, Tomas" <tomas.winkler@xxxxxxxxx>
> > >
> > > Utilize runtime_pm for driving tpm crb idle states.
> > > The framework calls cmd_ready from the pm_runtime_resume handler and
> > > go idle from the pm_runtime_suspend handler.
> > > The TPM framework should wake the device before transmit and receive.
> > > In case the runtime_pm framework is not compiled in or enabled, the
> > > device will be in the permanent ready state.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> >
> > I would rather want the fix as a separate patch to make review + testing easier
> > (without and with). Thanks.
>
> But you've dropped the patches, so I've resent them.
> Can you do the diff yourself, just branch it off. it's really just few lines

Nope. I have only dropped the workaround.

/Jarkko