Re: [PATCH v19 01/12] fpga: add bindings document for fpga region

From: Rob Herring
Date: Sat Oct 08 2016 - 16:49:49 EST

On Wed, Sep 28, 2016 at 01:21:49PM -0500, Alan Tull wrote:
> New bindings document for FPGA Region to support programming
> FPGA's under Device Tree control
> Signed-off-by: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Moritz Fischer <moritz.fischer@xxxxxxxxx>
> ---
> v9: initial version added to this patchset
> v10: s/fpga/FPGA/g
> replace DT overlay example with slightly more complicated example
> move to staging/simple-fpga-bus
> v11: No change in this patch for v11 of the patch set
> v12: Moved out of staging.
> Changed to use FPGA bridges framework instead of resets
> for bridges.
> v13: bridge@0xff20000 -> bridge@ff200000, etc
> Leave out directly talking about overlays
> Remove regs and clocks directly under simple-fpga-bus in example
> Use common "firmware-name" binding instead of "fpga-firmware"
> v14: Use firmware-name in bindings description
> Call it FPGA Area
> Remove bindings that specify FPGA Manager and FPGA Bridges
> v15: Cleanup as per Rob's comments
> Combine usage doc with bindings document
> Document as being Altera specific
> Additions and changes to add FPGA Bus
> v16: Reworked to document FPGA Regions
> rename altera-fpga-bus-fpga-area.txt -> fpga-region.txt
> Remove references that made it sound exclusive to Altera
> Remove altr, prefix from fpga-bus and fpga-area compatible strings
> Added Moritz' usage example with Xilinx
> Cleaned up unit addresses
> v17: Lots of rewrites to try to make things clearer
> Clarify that overlay can be rejected if FPGA isn't programmed
> Add external-fpga-config binding already used in u-boot
> Change partial-reconfig binding to partial-fpga-config to align
> with existing u-boot binding format *-fpga-config
> Add a document from Xilinx' website
> v18: Fix node names underscores to be hyphens
> Fix copy/pasted duplicate nodes in diagram
> v19: Fix more underscores
> Make FPGA regions to be children of bridges
> General cleanup and clarification
> ---
> .../devicetree/bindings/fpga/fpga-region.txt | 494 +++++++++++++++++++++
> 1 file changed, 494 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fpga/fpga-region.txt

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Nice job.