Re: [PATCH] pinctrl: intel: Configure GPIO chip IRQ as wakeup interrupts

From: Andy Shevchenko
Date: Sun Oct 09 2016 - 13:17:44 EST


On Sun, Oct 9, 2016 at 5:59 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Fri, Oct 07, 2016 at 10:40:42PM +0300, Andy Shevchenko wrote:
>> On Fri, Oct 7, 2016 at 9:17 PM, Bacchewar, Nilesh
>> <nilesh.bacchewar@xxxxxxxxx> wrote:
>> > Here, Its marking GPIO controller IRQ line as wake capable not GPIO lines.
>>
>> AFAIU this is called per (GPIO) pin which is IRQ enabled.
>>
>> Imagine a case when you have more than one such pin.
>>
>> 1. Set IRQ wake for pin 1
>> 2. Set IRQ wake for pin 2 (assume that is pin under the question)
>> 3. Unset IRQ wake for pin 1 (for some reason)
>> 4. Global pinctrl IRQ wake is unset. Resulting same issue as before.
>>
>> What did I miss above?
>
> enable/disable_irq_wake() include reference count.

Good to know. Thanks!

--
With Best Regards,
Andy Shevchenko