Re: [RFC][PATCHv2 0/7] printk: use alt_printk to handle printk() recursive calls
From: Sergey Senozhatsky
Date: Sun Oct 09 2016 - 21:20:00 EST
On (10/06/16 17:55), Petr Mladek wrote:
> On Sat 2016-10-01 00:17:51, Sergey Senozhatsky wrote:
> > Hello,
> > RFC
> > This patch set extends a lock-less NMI per-cpu buffers idea to
> > handle recursive printk() calls. The basic mechanism is pretty much the
> > same -- at the beginning of a deadlock-prone section we switch to lock-less
> > printk callback, and return back to a default printk implementation at the
> > end; the messages are getting flushed to a logbuf buffer from a safer
> > context.
> OK, I think again that this patch set makes sense. It looks good after
> all my doubts ;-)
> Just I would like you to consider using some more meaningful name
> instead of the "alt" prefix. I wonder how the following prefix
> would look like:
sure. I want to rename it. not entirely sure that printk_safe_enter()
is the best option here, but I can't think of anything better.
> prefix rather than a suffix.
good point. will change to 'suffix'.
> Also "alt_printk_ctx" per-CPU variable describes a global
> printk state. I think that the alt_ prefix is not needed
> and "printk_context" would be better readable.
yep, will do. thanks.