Re: Change CONFIG_DEVKMEM default value to n

From: Dave Young
Date: Mon Oct 10 2016 - 01:35:58 EST


On 10/10/16 at 07:12am, Greg Kroah-Hartman wrote:
> On Mon, Oct 10, 2016 at 10:50:50AM +0800, Dave Young wrote:
> > On 10/10/16 at 10:44am, Dave Young wrote:
> > > On 10/07/16 at 05:57am, Greg Kroah-Hartman wrote:
> > > > On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote:
> > > > > Kconfig comment suggests setting it as "n" if in doubt thus move the
> > > > > default value to 'n'.
> > > > >
> > > > > Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>
> > > > > Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > > > > ---
> > > > > drivers/char/Kconfig | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > --- linux-x86.orig/drivers/char/Kconfig
> > > > > +++ linux-x86/drivers/char/Kconfig
> > > > > @@ -17,7 +17,7 @@ config DEVMEM
> > > > >
> > > > > config DEVKMEM
> > > > > bool "/dev/kmem virtual device support"
> > > > > - default y
> > > > > + default n
> > > >
> > > > If you remove the "default" line, it defaults to 'n'.
> > >
> > > I personally perfer a "default n", but I can update it..
> >
> > Greg, here is an update with dropping the default line:
>
> <snip>
>
> Can you resend it in a format I can apply it in?

Done, thanks you!

>
> thanks,
>
> greg k-h