Re: [PATCH 1/2] mfd: Add HiSilicon Flash Memory Controller(FMC) driver

From: Lee Jones
Date: Mon Oct 10 2016 - 03:20:41 EST


On Fri, 30 Sep 2016, linshunquan 00354166 wrote:

> From: Shunquan Lin <linshunquan1@xxxxxxxxxxxxx>
>
> This patch adds driver support for HiSilicon Flash Memory
> Controller(FMC). HiSilicon FMC is a multi-functions device which
> supports SPI Nor flash controller, SPI nand Flash controller and
> parallel nand flash controller.

This is not an MFD. MFDs span multiple subsystems, where as these are
all Memory Technology Devices (MTDs). Please find a way to support
this in the MTD subsystem.

> Signed-off-by: Shunquan Lin <linshunquan1@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/hisilicon,hisi-fmc.txt | 62 ++++++++++++
> drivers/mfd/Kconfig | 10 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/hisi_fmc.c | 109 +++++++++++++++++++++
> include/linux/mfd/hisi_fmc.h | 92 +++++++++++++++++
> 5 files changed, 274 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hisi-fmc.txt
> create mode 100644 drivers/mfd/hisi_fmc.c
> create mode 100644 include/linux/mfd/hisi_fmc.h

[...]

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog