Re: [PATCH 3/3] pinctrl: sunxi: Don't leak memory in case krealloc() failes

From: Linus Walleij
Date: Mon Oct 10 2016 - 04:44:16 EST


On Fri, Sep 30, 2016 at 2:14 PM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote:

> If krealloc() fails there's no way of freeing the memory previously allocated
> for pctl->functions as it is overwritten by krealloc()'s return value. Fix
> this by assigning the return value to a temporary variable first so we can do
> error handling (which we didn't do at all before).
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

Patch applied.

Yours,
Linus Walleij