Re: [PATCH v3 08/12] scsi/ncr5380: Use correct types for device register accessors
From: Russell King - ARM Linux
Date: Mon Oct 10 2016 - 05:19:18 EST
On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote:
> For timeout values adopt unsigned long, which is the type of jiffies etc.
> For chip register values and bit masks pass u8, which is the return type
> of readb, inb etc.
> For device register offsets adopt unsigned int, as it is suitable for
> adding to base addresses.
> Pass the NCR5380_hostdata pointer to the board-specific routines instead
> of the Scsi_Host pointer. The board-specific code is concerned with
> hardware and not with SCSI protocol or the mid-layer.
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
> Tested-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>
> Tested-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
> drivers/scsi/arm/cumana_1.c | 20 +++++++++++---------
> drivers/scsi/arm/oak.c | 6 ++----
For these two:
Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.