Re: [PATCH v7 1/6] perf annotate: Add cross arch annotate support
From: Ravi Bangoria
Date: Mon Oct 10 2016 - 09:29:55 EST
Sorry for little late replies, I was off last week.
Please find my comments.
On Wednesday 05 October 2016 04:49 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 21, 2016 at 09:17:51PM +0530, Ravi Bangoria escreveu:
>> Change current data structures and function to enable cross arch
>> Current perf implementation does not support cross arch annotate.
>> To make it truly cross arch, instruction table of all arch should
>> be present in perf binary. And use appropriate table based on arch
>> where perf.data was recorded.
>> tok = strchr(name, '>');
>> if (tok == NULL)
>> @@ -252,16 +253,12 @@ static int mov__parse(struct ins_operands *ops, struct map *map __maybe_unused)
>> return -1;
>> target = ++s;
>> -#ifdef __arm__
>> comment = strchr(s, ';');
>> - comment = strchr(s, '#');
>> + if (comment == NULL)
>> + comment = strchr(s, '#');
>> - if (comment != NULL)
>> - s = comment - 1;
>> - else
>> - s = strchr(s, '\0') - 1;
>> + s = (comment != NULL) ? comment - 1 : strchr(s, '\0') - 1;
> Why have you touched the above 4 lines? The code you provided is
> equivalent, i.e. has no value for this patch you're working on, just a
> distraction for reviewers, please don't do that.
Sorry about that. I did this change to make code more compact but
yes, you are right, that should be done as separate patch.