Re: [PATCH 1/4] base: soc: Early register bus when needed

From: Arnd Bergmann
Date: Mon Oct 10 2016 - 10:15:58 EST


On Tuesday, October 4, 2016 11:09:24 AM CEST Geert Uytterhoeven wrote:
> If soc_device_register() is called before soc_bus_register(), it crashes
> with a NULL pointer dereference.
>
> soc_bus_register() is already a core_initcall(), but drivers/base/ is
> entered later than e.g. drivers/pinctrl/ and drivers/soc/. Hence there
> are several subsystems that may need to know SoC revision information,
> while it's not so easy to initialize the SoC bus even earlier using an
> initcall.
>
> To fix this, let soc_device_register() register the bus early if that
> hasn't happened yet.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>

Not nice, but I can't think of a better alternative, so

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>