Re: [PATCH] scsi: NCR5380: no longer mark irq probing as __init

From: Finn Thain
Date: Tue Oct 11 2016 - 19:21:56 EST

On Tue, 11 Oct 2016, Ondrej Zary wrote:

> I've tested IRQ probing on my IRQ7-hardwired ISA card without any
> success some time ago. No IRQ was detected because it wasn't even
> generated (no increment in /proc/interruptts).

The IRQ line does not appear in /proc/interrupts unless it has already
been claimed. So if you saw that the interrupt count stayed the same, then
the interrupt line wasn't available in the first place.

> It also produced some warnings in dmesg about conflicting interrupt
> flags.

Presumably that's because there is no way to probe shared interrupt lines.

> Can't the IRQ probing be simply deleted?

It isn't clear to me that there's a bug in the driver. I never saw a bug
in the irq probe code when I went looking for a reason to delete that code
a while ago.

Anyway, assuming that the interrupt line on your card works fine, have you
considered using probe_irq_on/probe_irq_off? See for example, sym53c416.c
and NCR53c406a.c.

Bug or no bug, I'd be very happy to delete the NCR5380 probe code if we
can use the standard probe functions to retain the documented