Re: [PATCH 1/8] vfs - change d_manage() to take a struct path
From: Ian Kent
Date: Tue Oct 11 2016 - 19:47:50 EST
On Tue, 2016-10-11 at 11:04 -0500, Eric W. Biederman wrote:
> Ian Kent <raven@xxxxxxxxxx> writes:
> > For the autofs module to be able to reliably check if a dentry is a
> > mountpoint in a multiple namespace environment the ->d_manage() dentry
> > operation will need to take a path argument instead of a dentry.
> Taking a quick look overall I see no issues with this series. Overall
> it seems straight forward.
> On the nit side I expect saying const struct path * in the functions
> that now take a struct path would be useful.
> I suspect it would also be useful to say
> const struct path *path;
> path = &file->f_path;
> In the one part of the code where you do that. Instead of copying the
> path out of the struct file.
> Overall I expect that will keep down bugs at no reduction in usability.
> Just a statement that the struct path won't change when it is passed
> to various functions.
Thanks Eric, that's a good suggestion for a follow up patch, will do.