Re: [PATCH] kvm: x86: correct the misleading comment in vmx_handle_external_intr
From: Longpeng (Mike)
Date: Tue Oct 11 2016 - 21:16:01 EST
On 2016/10/12 2:23, Radim KrÄmÃÅ wrote:
> This part is acceptable as it gives a new information code, yet the
> function does not modify flags, which makes it unremarkable.
> And dependencies on the caller would be better described in a header
> (if we cannot express them well in the code).
> The most comment-worthy thing about this function is the reason why we
> execute the interrupt handler manually, i.e. the dependency on
> VM_EXIT_ACK_INTR_ON_EXIT, but that is easy to tell from the commit
> message and convenient access to git history is essential in a workflow,
> so providing a leeway could be counter-productive.
> I would go with no comment for now.
Thanks for your patience, and your advice is useful for me.
In addition, the comment below is misleading too, hope you can fix it
/* Interrupt is enabled by handle_external_intr() */