Re: [PATCH 1/7 v4] sched: factorize attach entity
From: Dietmar Eggemann
Date: Wed Oct 12 2016 - 07:12:19 EST
On 12/10/16 11:59, Vincent Guittot wrote:
> On 7 October 2016 at 01:11, Vincent Guittot <vincent.guittot@xxxxxxxxxx> wrote:
>> On 5 October 2016 at 11:38, Dietmar Eggemann <dietmar.eggemann@xxxxxxx> wrote:
>>> On 09/26/2016 01:19 PM, Vincent Guittot wrote:
>>>> -static void attach_task_cfs_rq(struct task_struct *p)
>>>> +static void attach_entity_cfs_rq(struct sched_entity *se)
>>>> - struct sched_entity *se = &p->se;
>>>> struct cfs_rq *cfs_rq = cfs_rq_of(se);
>>> Both callers of attach_entity_cfs_rq() already use cfs_rq_of(se). You
>>> could pass it into attach_entity_cfs_rq().
>> Yes that would make sense
> In fact there is a 3rd caller online_fair_sched_group which calls
> attach_entity_cfs_rq and doesn't already use cfs_rq_of(se) so i
> wonder if it's worth doing the interface change.
OK, this change gets in w/ patch 6/7. Yeah, skip it, it's not so important.